diff options
| author | Mel <einebeere@gmail.com> | 2023-07-07 23:05:14 +0200 |
|---|---|---|
| committer | Mel <einebeere@gmail.com> | 2023-07-07 23:14:59 +0200 |
| commit | 129f2e421e16bd008cdca8713cc91f67d103d94e (patch) | |
| tree | a4d3e1005c57591b44fd57be4c1b00441512e36d /src/World/Generation/ChunkMeshing.cpp | |
| parent | f1fc192ddc4c739fa8b4b376c759b7d3218a34eb (diff) | |
| download | meowcraft-129f2e421e16bd008cdca8713cc91f67d103d94e.tar.zst meowcraft-129f2e421e16bd008cdca8713cc91f67d103d94e.zip | |
Fix minor quality issues
Diffstat (limited to 'src/World/Generation/ChunkMeshing.cpp')
| -rw-r--r-- | src/World/Generation/ChunkMeshing.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/World/Generation/ChunkMeshing.cpp b/src/World/Generation/ChunkMeshing.cpp index 54abc85..0494da4 100644 --- a/src/World/Generation/ChunkMeshing.cpp +++ b/src/World/Generation/ChunkMeshing.cpp @@ -83,7 +83,7 @@ std::array<Vector<3>, 4> face_normals(BlockSide side) { return {normal, normal, normal, normal}; } -bool is_face_visible(Chunk& chunk, ChunkMeshing::ChunkNeighbors neighbors, uint32_t x, uint32_t y, uint32_t z, BlockSide side) { +bool is_face_visible(Chunk& chunk, const ChunkMeshing::ChunkNeighbors& neighbors, uint32_t x, uint32_t y, uint32_t z, BlockSide side) { Vector<3, int32_t> offset{}; switch (side) { case BlockSide::Front: @@ -128,15 +128,15 @@ bool is_face_visible(Chunk& chunk, ChunkMeshing::ChunkNeighbors neighbors, uint3 chunk_to_ask = &chunk; } - auto neighbor = chunk_to_ask->get(neighbor_pos.x(), neighbor_pos.y(), neighbor_pos.z()); - if (neighbor.type == BlockType::Air) { + auto [neighbor] = chunk_to_ask->get(neighbor_pos.x(), neighbor_pos.y(), neighbor_pos.z()); + if (neighbor == BlockType::Air) { return true; } return false; } -GFX::Mesh ChunkMeshing::create_mesh_for_chunk(Chunk& chunk, ChunkMeshing::ChunkNeighbors neighbors) { +GFX::Mesh ChunkMeshing::create_mesh_for_chunk(Chunk& chunk, const ChunkNeighbors& neighbors) { std::vector<Vector<3>> positions{}; std::vector<Vector<3>> normals{}; std::vector<Vector<2>> tex_coords{}; @@ -174,7 +174,7 @@ GFX::Mesh ChunkMeshing::create_mesh_for_chunk(Chunk& chunk, ChunkMeshing::ChunkN } } - return { + return GFX::Mesh{ {positions, normals, tex_coords}, indices, }; |
